Differential D3899

Applet: Make sure to never show empty icon
ClosedPublic
Actions

Authored by drosca on Jan 1 2017, 10:49 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R994:26dfed1e5df8: Applet: Make sure to never show empty icon
R115:26dfed1e5df8: Applet: Make sure to never show empty icon
Summary

Streams needs to have icon to be possible to drag them to different
devices. Show "unknown" icon when icon is empty or not found in theme.

Test Plan

Tried to set "asdas" as icon name, "unknown" icon was picked instead.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 9573.Jan 1 2017, 10:49 AM
drosca retitled this revision from to Applet: Make sure to never show empty icon.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2017, 10:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jan 1 2017, 7:34 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 1 2017, 7:34 PM
Closed by commit R115:26dfed1e5df8: Applet: Make sure to never show empty icon (authored by drosca). · Explain WhyJan 1 2017, 8:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9593

View Options

applet/contents/ui/DeviceListItem.qml

Loading...
View Options

applet/contents/ui/ListItemBase.qml

Loading...
View Options

applet/contents/ui/StreamListItem.qml

Loading...