Replaced InputEventFilter by InputEventSpy
ClosedPublic
Actions

Authored by floeser on Dec 30 2016, 6:51 PM.

Details

Reviewers

kwin
graesslin

Commits

Summary

As explained in 84e33081499fd0049fbe7908dd7b66b2eefd34b1
the DebugConsole should use an InputEventSpy instead of an InputEventFilter.

Repository

R108 KWin

Branch

DebugConsoleSpy

Lint

No Linters Available

Unit

No Unit Test Coverage

floeser retitled this revision from to Replaced InputEventFilter by InputEventSpy.

floeser updated this object.

floeser edited the test plan for this revision. (Show Details)

floeser added a reviewer: kwin.

Restricted Application added a project: KWin. · View Herald TranscriptDec 30 2016, 6:51 PM

graesslin added inline comments.

debug_console.cpp
188–191	you could also drop this cast as it's now a MouseEvent in all cases. So just replace it by: #if HAVE_INPUT text.append(event->device()); #endif Similar code should also be in MouseButtonPress/Release switch, and the methods keyEvent and wheelEvent

Removed casts in MouseEvents as request in code review.

graesslin added a reviewer: graesslin.

This revision is now accepted and ready to land.Jan 1 2017, 5:03 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			debug_console.h (35 lines)
M			debug_console.cpp (73 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9512	a9ac70f		Dec 30 2016, 6:51 PM	★	★
Diff 2	9587	a9ac70f	Removed casts in MouseEvents as request in code review.	Jan 1 2017, 4:50 PM	★	★
Diff 3	9589	a9ac70f	R108:9cc7d12158fa77269c5cb73113da304010ce2b51	Jan 1 2017, 6:06 PM	★	★