Differential D3878

Use removeOne when uninstalling an InputEventFilter
ClosedPublic
Actions

Authored by graesslin on Dec 30 2016, 6:25 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
KWin
Commits
R108:a8db96750595: Use removeOne when uninstalling an InputEventFilter
Summary

Adjusting to a difference from introducing the InputEventSpy. A filter
may only be installed once. Thus removeOne is totally sufficient.

Added a Q_ASSERT to ensure that it is not installed when installing.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 9511.Dec 30 2016, 6:25 PM
graesslin retitled this revision from to Use removeOne when uninstalling an InputEventFilter.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptDec 30 2016, 6:25 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 2 2017, 10:13 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

fine as the asserts guards more than one is never added

input.cpp
1378

i know OT, but would be possible for this not being public api for the typo to be fixed?

This revision is now accepted and ready to land.Jan 2 2017, 10:13 AM
graesslin added inline comments.Jan 2 2017, 6:51 PM
input.cpp
1378

uh, nice spotting. Yeah will fix it.

Closed by commit R108:a8db96750595: Use removeOne when uninstalling an InputEventFilter (authored by graesslin). · Explain WhyJan 2 2017, 7:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minput.cpp (4 lines)

Diff 9614

View Options

input.cpp

Loading...