Use FindALSA provided by cmake
ClosedPublic

Authored by heikobecker on Dec 29 2016, 5:16 PM.

Details

Summary

...instead of using a copy from KDELibs4Supprt. It has been included
since cmake-2.8.0.

Furthermore drop the special casing for <sys/asoundlib.h> which has
been deprecated since 2001, according to [1].

[1] http://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=6157018e8ad7179271791f960570db79b23a481d

Diff Detail

Repository
R349 KCompactDisc Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker updated this revision to Diff 9461.Dec 29 2016, 5:16 PM
heikobecker retitled this revision from to Use FindALSA provided by cmake.
heikobecker updated this object.
heikobecker edited the test plan for this revision. (Show Details)
ltoscano accepted this revision.Dec 30 2016, 3:45 PM
ltoscano edited edge metadata.

It definitely looks good to me. The result is exactly the same (as expected). No other references to the old defines remains. Unless Leslie want to comment, I would say that it is not a regression compared to the current code and there is time to fix it.

This revision is now accepted and ready to land.Dec 30 2016, 3:45 PM
This revision was automatically updated to reflect the committed changes.