Don't test QIcon equality, it is too brittle
ClosedPublic
Actions

Authored by ervin on Dec 29 2016, 3:20 PM.

Details

Reviewers

dfaure

Group Reviewers

Zanshin

Commits

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin retitled this revision from to Don't test QIcon equality, it is too brittle.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added a reviewer: Zanshin.

dfaure edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2016, 8:55 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/units/widgets/filterwidgettest.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9457	dbc757f		Dec 29 2016, 3:20 PM	★	★
Diff 2	9486	54846a7	R4:771ca38fa875dbe3f9e244b824cac4d043844d61	Dec 30 2016, 10:12 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a08c19ffcdce	f75cee12b9d9	dbc757f502d3	Kevin Ottens	Don't test QIcon equality, it is too brittle	Dec 29 2016, 3:18 PM