Fixes case when scrollbar have the scrolling widget as focus proxy.
Details
Details
- Reviewers
hpereiradacosta - Group Reviewers
Plasma - Commits
- R31:278876855b37: Draw scrollbar as focused when scrollbar itself have focus
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hi, ,Thanks for the patch !
Do you have an example application for which this fixes the issue ?
I'm a bit worried about the possible regressions that your change introduced, so I would like to understand better what happens here ...
| kstyle/breezestyle.cpp | ||
|---|---|---|
| 3067 | You sure this is actually needed ? The primitive is supposed to do an horizontal line below the passed rect. Never seen that happened for scrollbars. Does it really ? (without the patch) | |
Comment Actions
Currently, it tries to find QAbstractScrollArea in parent chain and use focused state of this scroll area (+ there is a special case for KTextView). There is no standard way to specify the widget that is being scrolled by the scrollbar. This only works with standard Qt widgets and breaks when you implement custom widget that uses scrollbars.
This proposed solution also checks if the scrollbar itself have the focus, which I think makes sense and should not have any side-effects. Even in the case when scrollbar is actually able to get focus (ie scrollbar having focus while the scrolled widget not having it) it still should be rendered as focused, because it *is* focused.
My use case is scrollbar controlling widget that is not parent of the scrollbar and scrollbar having focusproxy the scrolled widget.
| kstyle/breezestyle.cpp | ||
|---|---|---|
| 3067 | Yes, this is needed because it is painted when the scrollbar have focus (which is the case this patch is trying to support). | |
Comment Actions
Ok. I buy it. Thanks for the clarification.
Ship it then. (and feel free to push the same for oxygen)