Fix the osd re-placement on X11
ClosedPublic
Actions

Authored by graesslin on Dec 26 2016, 10:13 AM.

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

R108:bba18a1ba812: Fix the osd re-placement on X11

Summary

6383f8304711719fe22371474138efc144adc750 introduced a regression hitting
an assert on X11 when an osd window is added.

This change tries to address this by adding a GeometryUpdateBlocker
around the change. The hit assertion is:

pendingGeometryUpdate() == PendingGeometryNone ||
areGeometryUpdatesBlocked()

By using a GeometryUpdateBlocker the second condition becomes true
and we no longer hit the condition.

BUG: 374038

Test Plan

Manual tested both on X11 and Wayland, Wayland autotest
still passes

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Fix the osd re-placement on X11.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Dec 27 2016, 4:32 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			abstract_client.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9362	ab45659		Dec 26 2016, 10:13 AM	★	★
Diff 2	9390	2b51b85	R108:bba18a1ba812f3a147173edc19516f0e00e7c855	Dec 27 2016, 4:36 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9947f81b5ef4	f21929edbbfb	ab456596777a	Martin Gräßlin	Fix the osd re-placement on X11 (Show More…)	Dec 26 2016, 10:04 AM