Differential D3795

Fix clearing PageRow
ClosedPublic
Actions

Authored by apol on Dec 22 2016, 6:52 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:3e7695f51e05: Fix clearing PageRow
Summary

Makes sense because we grow in depth, so it makes sense that we free the
resources in the same order.
Clear from end to beginning rather than the other way around. It would cause
crashes in Discover (within QtQuick).

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 9300.Dec 22 2016, 6:52 PM
apol retitled this revision from to Fix clearing PageRow.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 22 2016, 6:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 22 2016, 8:17 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2016, 8:17 PM
Closed by commit R169:3e7695f51e05: Fix clearing PageRow (authored by apol). · Explain WhyDec 23 2016, 12:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/PageRow.qml (2 lines)

Diff 9309

View Options

src/controls/PageRow.qml

Loading...