Recheck which representation we should using in setPreferredRepresentation
ClosedPublic

Authored by davidedmundson on Dec 22 2016, 4:57 PM.

Details

Summary

Appmenu quite neatly has a config option for which should be the
preferred representation, which is needed as both things are quite
viable in a panel and can't be done automatically.

AppletQuickItem needs to update which representation to use when this is
set at runtime. We already check on every single geometry change, so
one extra check won't have a huge impact.

Test Plan

Appmenu changes dynamically
All other applets (both compact and normal) still seem fine

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Recheck which representation we should using in setPreferredRepresentation.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 22 2016, 4:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 22 2016, 5:01 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Dec 22 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.