Differential D3793

add keybpard navigation for listviews
ClosedPublic
Actions

Authored by mart on Dec 22 2016, 4:49 PM.

Details

Reviewers
apol
Group Reviewers
Kirigami
Commits
R169:c1175dc6e488: add keybpard navigation for listviews
Summary

when the main item of a scrollablepage is a listview, use
arrows to navigate

Test Plan

works fine in the gallery

Diff Detail

Repository
R169 Kirigami
Branch
phab/keybnavig
Lint
No Linters Available
Unit
No Unit Test Coverage
mart updated this revision to Diff 9292.Dec 22 2016, 4:49 PM
mart retitled this revision from to add keybpard navigation for listviews.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Kirigami.
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 22 2016, 4:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Dec 22 2016, 5:00 PM

I thought we wanted to make it optional.
Also a test would be great :D.

mart added a comment.Dec 22 2016, 5:13 PM
In D3793#70872, @apol wrote:

I thought we wanted to make it optional.
Also a test would be great :D.

just an "usesKeyboardNavigation" bool property?

apol added a comment.Dec 22 2016, 5:32 PM

Yes, that's what I had in mind.

Why didn't you include the next/prev page thing from my implementation?

mart updated this revision to Diff 9298.Dec 22 2016, 6:18 PM

add a simple test

mart updated this revision to Diff 9299.Dec 22 2016, 6:19 PM

add copyright

apol accepted this revision.Dec 22 2016, 6:53 PM
apol added a reviewer: apol.

Looks good, please note there seems to be an unrelated change.

src/controls/AbstractApplicationWindow.qml
143 ↗(On Diff #9299)

Unrelated?

This revision is now accepted and ready to land.Dec 22 2016, 6:53 PM
apol requested changes to this revision.Dec 22 2016, 7:38 PM
apol edited edge metadata.

Ah no, still needs the property.
How about property bool keyboardEnabled: true?

This revision now requires changes to proceed.Dec 22 2016, 7:38 PM
mart updated this revision to Diff 9317.Dec 23 2016, 9:42 AM
mart edited edge metadata.
  • keyboardNavigationEnabled property
apol accepted this revision.Dec 23 2016, 12:13 PM
apol edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2016, 12:13 PM
Closed by commit R169:c1175dc6e488: add keybpard navigation for listviews (authored by mart). · Explain WhyDec 23 2016, 12:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9317

View Options

autotests/tst_listskeynavigation.qml

Loading...
View Options

examples/gallery/contents/ui/MainPage.qml

Loading...
View Options

src/controls/AbstractApplicationWindow.qml

Loading...
View Options

src/controls/ScrollablePage.qml

Loading...
View Options

src/styles/Desktop/OverlayDrawer.qml

Loading...
View Options

tests/KeyboardListTest.qml

Loading...