Differential D3764

Make sure that triggering a menu action keeps respecting its action value
ClosedPublic
Actions

Authored by apol on Dec 20 2016, 5:12 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:1a217b53d010: Make sure that triggering a menu action keeps respecting its action value
Summary

Kirigami.Action.checked is designed so that the user has to change its value
upon triggered rather than having it change automatically.
Make sure this behavior is respected on the GlobalDrawer

Test Plan

In discover, when showing a section already, it doesn't think it's
changed when clicking it again.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 9228.Dec 20 2016, 5:12 PM
apol retitled this revision from to Make sure that triggering a menu action keeps respecting its action value.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 20 2016, 5:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 21 2016, 5:07 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2016, 5:07 PM
Closed by commit R169:1a217b53d010: Make sure that triggering a menu action keeps respecting its action value (authored by apol). · Explain WhyDec 21 2016, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/GlobalDrawer.qml (1 line)

Diff 9261

View Options

src/controls/GlobalDrawer.qml

Loading...