Differential D3761

Don't double emit iconChanged
ClosedPublic
Actions

Authored by davidedmundson on Dec 20 2016, 12:13 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R242:7e1f2d79dafa: Don't double emit iconChanged
Summary

AppletInterface::setIcon calls Applet::setIcon which in turn emits
Applet::iconChanged

Applet::iconChanged is already connected to
AppletInterface::iconChanged

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 9215.Dec 20 2016, 12:13 PM
davidedmundson retitled this revision from to Don't double emit iconChanged.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 20 2016, 12:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Dec 20 2016, 1:22 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Dec 20 2016, 1:22 PM
Closed by commit R242:7e1f2d79dafa: Don't double emit iconChanged (authored by davidedmundson). · Explain WhyDec 20 2016, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9219

View Options

src/scriptengines/qml/plasmoid/appletinterface.cpp

Loading...