expose toggleWidgetExplorer through dbus
ClosedPublic

Authored by mvourlakos on Dec 20 2016, 8:16 AM.

Details

Summary

--shows/hides the WidgetExplorer through dbus

Test Plani: trigger widget explorer from command line

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mvourlakos updated this revision to Diff 9205.Dec 20 2016, 8:16 AM
mvourlakos retitled this revision from to expose toggleWidgetExplorer through dbus.
mvourlakos updated this object.
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 20 2016, 8:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Code is fine, but what's the intended use?

Code is fine, but what's the intended use?

Intended use is for all the apps that leave outside plasmashell and want to provide a unified experience with it... Such a case is the next version of Now Dock...

Now Dock in version 0.6 will possibly be an executable outside plasmashell. It will provide its own corona and containments in order to look and behave as part of the plasma experience. We are discussing that change because with version 0.5 Now Dock reached a point of maturity but there are things that are not letting it mature more... Main concerns are:

1.two different panel settings dialogs one for original plasma settings and one for Now Dock settings,
2.Now Dock can not access all the settings from the plasma's PanelView
3.Now Dock in order to provide its functionality provides a second window above the original plasma's panel and in order to co-operate with the original panel window (concerning also the 2 issue) does not provide a clean code that can mature and extend easily

the above lead to a new implementation outside plasmashell but that co-operate cleanly, main things that are missing for this communication between plasmashell and nowdock are:
1.toggle widgets explorer through dbus
2.access plasmashell's immutability change through dbus
3.change immutability state of plasmashell through dbus
4.signal for immutability changed of plasmashell through dbus

this patch is for (1)

davidedmundson accepted this revision.Dec 20 2016, 3:02 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Dec 20 2016, 3:02 PM
This revision was automatically updated to reflect the committed changes.
mart edited edge metadata.Dec 21 2016, 10:39 AM

I disagree, this commit should be reverted

mart reopened this revision.Dec 21 2016, 10:39 AM
This revision is now accepted and ready to land.Dec 21 2016, 10:39 AM
mart added a comment.Dec 21 2016, 11:17 AM

expanding of why it should be reverted
Its only use case is for another process that wants to pretend it's part of the shell, which is not a supported use case neither should be, both for sake of maintainability and of course wayland.