Differential D3751

Fix color space name inconsistencies
AbandonedPublic
Actions

Authored by rempt on Dec 20 2016, 6:16 AM.

Details

Reviewers

nicholasl

Group Reviewers

Krita

Summary

Fixes these inconsistencies that appear in the user-visible color space names:

16-bit float XYZ reported "XYZ (32-bit float/channel)"
8-bit/16-bit float RGB and Grayscale were the only color spaces that included the alpha channel in their names

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

nicholasl updated this revision to Diff 9202.Dec 20 2016, 6:16 AM

nicholasl retitled this revision from to Fix color space name inconsistencies.

nicholasl updated this object.

nicholasl edited the test plan for this revision. (Show Details)

nicholasl added a reviewer: Krita.

nicholasl set the repository for this revision to R37 Krita.

The xyz thing needs fixing, for sure. About the others, I'm not so sure: it might confuse people who see the name and then think "oh, no alpha channel". I'd like to get some more input from others on this question.

I wasn't sure either. I'd actually prefer to list the alpha channel in all color spaces.
Is there any place you'd like me to post about this so we can get opinions?

I pushed just the XYZ string to master for now.

Maybe best ask around on irc?

Any updates on this? Personally, I'm okay with pushing this patch to master.

rempt requested changes to this revision.Jul 6 2017, 12:16 PM

This revision now requires changes to proceed.Jul 6 2017, 12:16 PM

It's already pushed. afaik.

Revision Contents
Changeset List

			Path	Packages
M			plugins/color/lcms2engine/colorspaces/gray_f16/GrayF16ColorSpace.h (2 lines)
M			plugins/color/lcms2engine/colorspaces/gray_f32/GrayF32ColorSpace.h (2 lines)
M			plugins/color/lcms2engine/colorspaces/rgb_f16/RgbF16ColorSpace.h (2 lines)
M			plugins/color/lcms2engine/colorspaces/rgb_f32/RgbF32ColorSpace.h (2 lines)
M			plugins/color/lcms2engine/colorspaces/xyz_f16/XyzF16ColorSpace.h (2 lines)