Differential D3729

[KPropertiesDialog] Don't change "Name" of "Link" .desktop files if file name is read-only
ClosedPublic
Actions

Authored by broulik on Dec 19 2016, 8:22 AM.

Details

Reviewers
dfaure
Commits
R241:8f732677b69f: [KPropertiesDialog] Don't change "Name" of "Link" .desktop files if file name…
Summary

If the user cannot change the file name, don't update the "Name" field when applying changes.

Test Plan

I can now change the icon of an icon widget pointing to a file (creates a Link desktop file in ~/.local/share/plasma_icons) without suddenly the Name reflecting the underlying file name.

I also verified that when I can change the file name, it still updates the Name field when applying.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9150.Dec 19 2016, 8:22 AM
broulik retitled this revision from to [KPropertiesDialog] Don't change "Name" of "Link" .desktop files if file name is read-only.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: dfaure.
broulik set the repository for this revision to R241 KIO.
dfaure accepted this revision.Dec 22 2016, 9:03 PM
dfaure edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2016, 9:03 PM
Closed by commit R241:8f732677b69f: [KPropertiesDialog] Don't change "Name" of "Link" .desktop files if file name… (authored by broulik). · Explain WhyDec 23 2016, 9:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9319

View Options

src/widgets/kpropertiesdialog.cpp

Loading...
View Options

src/widgets/kpropertiesdialog_p.h

Loading...