As discussed in https://git.reviewboard.kde.org/r/129648/ we cannot use
KWindowEffects from a tier 1 framework. So we just introduce a new property
that hints for this feature and we move the code here (both in the x11 and
wayland event filters).
Details
Details
builds.
Diff Detail
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/platformtheme/kwaylandintegration.cpp | ||
|---|---|---|
| 35 | just wondering: we once have here a QByteArray and once a const char[] - shouldn't we use the same in both? | |
| 85–87 | What about the variant being false? Shouldn't we check the value and then either enable/disable the blur behind? Also should we support changes at runtime? Not saying we should, just asking ;-) | |
| src/platformtheme/kwaylandintegration.cpp | ||
|---|---|---|
| 35 | I used char[] for consistency with the old code, but I can use QByteArray if you prefer | |
| 85–87 |
Maybe we should do it when the property is valid but false? If we do it when the property is invalid/unset I think we could break something?
I'm not sure about this, but if one doesn't want the blur effect they can disable the property before showing the tooltip. This should be enough, I suppose (maybe worth a note it in the tooltip's apidox though). | |