Differential D3708

sgp4: Patch source to make it compile with libc++
ClosedPublic
Actions

Authored by kfunk on Dec 16 2016, 4:02 PM.

Details

Reviewers
nienhueser
Group Reviewers
Marble
Commits
R34:f8284708f0ea: sgp4: Patch source to make it compile with libc++
Summary

asinh is part of math.h since C99 times, there's no need to define it
ourselves.

Fixes compilation with Clang:
.../marble/src/3rdparty/sgp4/sgp4ext.cpp:210:9:
error: 'asinh' is missing exception specification 'throw()'
double  asinh
        ^
.../marble/src/3rdparty/sgp4/sgp4ext.h:65:9: note:
previous declaration is here
double  asinh
        ^

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 9089.Dec 16 2016, 4:02 PM
kfunk retitled this revision from to sgp4: Patch source to make it compile with libc++.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
kfunk updated this object.Dec 16 2016, 4:02 PM
kfunk added a reviewer: Marble.

Interesting that Phab detects that .cpp as binary... Be assured: I only deleted the asinh definition in that file...

nienhueser accepted this revision.Dec 16 2016, 7:22 PM
nienhueser added a reviewer: nienhueser.
nienhueser added a subscriber: nienhueser.

Seems fine to me.

This revision is now accepted and ready to land.Dec 16 2016, 7:22 PM
Closed by commit R34:f8284708f0ea: sgp4: Patch source to make it compile with libc++ (authored by kfunk). · Explain WhyDec 16 2016, 8:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9093

View Options

src/3rdparty/sgp4/sgp4ext.h

Loading...
View Options

src/3rdparty/sgp4/sgp4ext.cpp

Loading...