Fix inconsistency in commit 13f3244 (race condition between editing and saving).
ClosedPublic

Authored by dfaure on Dec 16 2016, 8:58 AM.

Details

Summary

Due to a change of heart mid-implementation, the property name set by the view
and the property name checked by the model differed.

And yet all automated tests passed... because they played along with the
two different property names, oops. This confirms to me that proper C++ method
calls checked by the compiler are actually superior than string-based architectures...

Test Plan

Editing and leaving a trailing space for a few seconds no longer makes
the cursor jump to pos 0.

Due to a new setup I wasn't able to run all automated tests
(cucumber packaging problem in OpenSuSE Leap 42.2; akonadi PayloadExceptions
in many tests). editorviewtest passes though.

Diff Detail

Repository
R4 Zanshin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure updated this revision to Diff 9060.Dec 16 2016, 8:58 AM
dfaure retitled this revision from to Fix inconsistency in commit 13f3244 (race condition between editing and saving)..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a reviewer: ervin.
dfaure added a subscriber: Zanshin.
ervin accepted this revision.Dec 19 2016, 9:18 PM
ervin edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2016, 9:18 PM
dfaure closed this revision.Dec 19 2016, 11:08 PM