Differential D3692

Remove redundant clear button
ClosedPublic
Actions

Authored by kfunk on Dec 15 2016, 10:34 PM.

Details

Reviewers
chehrlic
Commits
R220:616737e86fa9: Fix D3692 - KUrlRequester already has a clear button, no need to add another one
Summary

The line edit already has a 'Clear text' button

Diff Detail

Repository
R220 Subversion Client (KDE SVN)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
kfunk updated this revision to Diff 9052.Dec 15 2016, 10:34 PM
kfunk retitled this revision from to Remove redundant clear button.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
chehrlic accepted this revision.Dec 20 2016, 8:17 AM
chehrlic edited edge metadata.

You're correct - looks like KUrlRequester from KDE4 did not had a clear button :)
Tried to auto-close this but maybe found not the correct keywords - the documentation at https://secure.phabricator.com/T5132 does not mention differential tasks at all ...

This revision is now accepted and ready to land.Dec 20 2016, 8:17 AM
chehrlic closed this revision.Dec 20 2016, 8:17 AM

Revision Contents
Changeset List

PathPackages
Msrc/urldlg.h (2 lines)
Msrc/urldlg.cpp (6 lines)

Diff 9052

View Options

src/urldlg.h

Loading...
View Options

src/urldlg.cpp

Loading...