Use star symbols for capitals
ClosedPublic

Authored by Sergobot on Dec 13 2016, 8:59 PM.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Sergobot updated this revision to Diff 8988.Dec 13 2016, 8:59 PM
Sergobot retitled this revision from to Use star symbols for capitals.
Sergobot updated this object.
Sergobot edited the test plan for this revision. (Show Details)
Sergobot added reviewers: rahn, nienhueser.
Sergobot added subscribers: rahn, nienhueser.

Unfortunately, I was unable to test. I have created a map of capitals, using populated places map from Natural Earth and tools/shp2osm/polyshp2osm.py. How do I load it into Marble?
The result file is

Sergobot added a comment.EditedDec 15 2016, 12:53 PM

I tried the tool you've mentioned. I called $ python ne_tilegenerator.py -z 9 but at a certain moment it crashed. After a little investigation I got that the problem is in marble-vectorosm-tilecreator -e o5m -z 9 -s ./cities15000.txt/cities15000.txt tiny_planet_9.1.osm.
tiny_planet_9.1.osm is 884 MB.

Backtrace:

#0  0x00007ffff7560918 in Marble::GeoDataContainer::d_func() const (this=0x8)
    at /home/sergobot/kde/src/marble/src/lib/marble/geodata/data/GeoDataContainer.h:183
#1  0x00007ffff755fdbd in Marble::GeoDataContainer::placemarkList() const (this=0x8)
    at /home/sergobot/kde/src/marble/src/lib/marble/geodata/data/GeoDataContainer.cpp:242
#2  0x0000000000420ff1 in Marble::BaseFilter::BaseFilter(Marble::GeoDataDocument*) (this=0x7fffffffce50, document=0x0)
    at /home/sergobot/kde/src/marble/tools/vectorosm-tilecreator/BaseFilter.cpp:22
#3  0x000000000043e0e1 in Marble::VectorClipper::VectorClipper(Marble::GeoDataDocument*, int) (this=0x7fffffffce50, document=0x0, maxZoomLevel=9)
    at /home/sergobot/kde/src/marble/tools/vectorosm-tilecreator/VectorClipper.cpp:35
#4  0x0000000000414a33 in main(int, char**) (argc=10, argv=0x7fffffffdc48)
    at /home/sergobot/kde/src/marble/tools/vectorosm-tilecreator/vectorosm-tilecreator.cpp:194

Btw, marble-vectorosm-tilecreator ate a lot of my memory - nearly 7.5 GB (I have 8 GB RAM and 9 GB swap, hope it's enough).

nienhueser accepted this revision.Dec 16 2016, 8:19 PM
nienhueser edited edge metadata.

Looks fine.

src/lib/marble/StyleBuilder.cpp
310

The '.svg' must be removed to have them show up. I'll fix this when committing.

This revision is now accepted and ready to land.Dec 16 2016, 8:19 PM
This revision was automatically updated to reflect the committed changes.