Set Automatic login flag to adjust SDDM config directly
ClosedPublic

Authored by davidedmundson on Dec 13 2016, 12:03 AM.

Details

Summary

AccountsService is a bit weird, the automatic login flag adjusts a
config file in /etc/gdm/

This doesn't work for two reasons:

  1. SDDM (our Display Manager) obviously doesn't read this file
  2. AccountsService doesn't create the folder if it doesn't exist, so we

can't even use if we tried.

This patch adjusts UserManager to write /etc/sddm.conf directly. It's
not ideal, but I think it's the only option we have, certainly in the
short term.

BUG: 363058

Test Plan

Set automatic login on a user
Restarted KCM, still set
Set it on another user, config changed properly, old user was updated
Unchecked it on my current user, config file was unset properly

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Set Automatic login flag to adjust SDDM config directly.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2016, 12:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Dec 13 2016, 11:01 AM

did the helper already supported the action or is a different rr?

Already exists in the sddm kcm.

mart accepted this revision.Dec 14 2016, 10:27 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Dec 14 2016, 10:27 AM
This revision was automatically updated to reflect the committed changes.