Show deli, tobacco and tea shops
ClosedPublic
Actions

Authored by xdizzaster on Dec 10 2016, 9:28 PM.

Details

Reviewers

nienhueser
rahn

Commits

R34:f27761a62d9a: Show deli, tobacco and tea shops

Summary

Added OSM Vectormap rendering for delis, tobacco shops and tea shops with proper icon.

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

xdizzaster retitled this revision from to Show deli, tobacco and tea shops.

xdizzaster updated this object.

xdizzaster edited the test plan for this revision. (Show Details)

xdizzaster set the repository for this revision to R34 Marble.

xdizzaster added a project: Marble.

xdizzaster added a subscriber: Marble.

src/lib/marble/StyleBuilder.cpp
2383	Why are you removing deli etc from this list?
src/lib/marble/declarative/Placemark.cpp
153	Not needed, will be added for any visual category. Same for the other ones below.

nienhueser requested changes to this revision.Dec 10 2016, 10:16 PM

nienhueser edited edge metadata.

This revision now requires changes to proceed.Dec 10 2016, 10:16 PM

src/lib/marble/StyleBuilder.cpp
2383	Because if they are on that list, marble treats them as generic shop type (the purple dot thing), as seen here.
src/lib/marble/declarative/Placemark.cpp
153	Will update shortly.

Removed a redundant tag.

Looks good. I'll commit it tomorrow morning.

This revision is now accepted and ready to land.Dec 10 2016, 11:36 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/marble/StyleBuilder.cpp (18 lines)
M			src/lib/marble/declarative/Placemark.cpp (16 lines)
M			src/lib/marble/geodata/data/GeoDataPlacemark.h (3 lines)
M			src/lib/marble/geodata/data/GeoDataPlacemark.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8913			Dec 10 2016, 9:26 PM	★	★
Diff 2	8916			Dec 10 2016, 10:43 PM	★	★
Diff 3	8921	8ab745e	R34:f27761a62d9af9ebc68b68ff8c06c83f0275e5f4	Dec 11 2016, 9:23 AM	★	★