Differential D3635

macOS: create a standalone bundle, introduce tools/create_dmg
Needs ReviewPublic
Actions

Authored by whitegeorge on Dec 10 2016, 10:24 AM.

Details

Reviewers
None
Group Reviewers
Marble
Summary

Google Code-in task.

Test Plan
  1. Build Marble against Qt from qt.io.
  2. Pass the app to tools/create_dmg/create.py as -i or --app, and pass the new DMG path as -o or --out.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
whitegeorge updated this revision to Diff 8900.Dec 10 2016, 10:24 AM
whitegeorge retitled this revision from to macOS: create a standalone bundle, introduce tools/create_dmg.
whitegeorge updated this object.
whitegeorge edited the test plan for this revision. (Show Details)
whitegeorge added a reviewer: Marble.
whitegeorge set the repository for this revision to R34 Marble.
whitegeorge added a project: Marble.
whitegeorge added inline comments.Dec 10 2016, 10:26 AM
tools/create_dmg/create.py
9

I need to get this from CMake.

whitegeorge added a comment.Dec 10 2016, 10:36 AM

The resultant DMG looks like this on mount:

nienhueser added a subscriber: nienhueser.Dec 10 2016, 10:45 AM
nienhueser added inline comments.
tools/create_dmg/create.py
2

Please add the typical license header, see e.g. https://cgit.kde.org/marble.git/tree/tools/vectortilecreator/vectortilecreator.py and your name and mail address as author.

39

shutil.copytree seems better, see https://docs.python.org/3.5/library/shutil.html

52

Please use shutil.copyfile

68

Please use shutil.rmtree

74

Please add a help entry also, same below.

whitegeorge updated this revision to Diff 8902.Dec 10 2016, 11:03 AM

Reflected @nienhueser's comments on the original patch.

whitegeorge updated this revision to Diff 8903.Dec 10 2016, 11:11 AM

Minor style changes.

whitegeorge planned changes to this revision.Dec 10 2016, 11:12 AM
whitegeorge marked 5 inline comments as done.
whitegeorge updated this revision to Diff 8904.Dec 10 2016, 11:14 AM

Removed time from the import.

nienhueser added inline comments.Dec 10 2016, 11:17 AM
tools/create_dmg/create.py
2

Should by python, not Python

whitegeorge updated this revision to Diff 8905.Dec 10 2016, 11:19 AM

Use shutil.copytree

whitegeorge updated this revision to Diff 8906.Dec 10 2016, 11:21 AM

Corrected uppercase P in crunchbang.

whitegeorge marked an inline comment as done.Dec 10 2016, 11:22 AM

Mark comment as finished.

whitegeorge updated this revision to Diff 8907.Dec 10 2016, 11:26 AM

consistent use of os.path.join

whitegeorge updated this revision to Diff 8908.Dec 10 2016, 12:01 PM

Corrected an accidental delete of DMG_APP variable assignment line.

whitegeorge marked an inline comment as done.Dec 11 2016, 11:21 AM
ngraham added a subscriber: ngraham.Oct 23 2017, 12:17 AM

How are we doing here? Can we land this?

Revision Contents
Changeset List

Diff 8908

View Options

install_mac/1-release-extra.sh

Loading...
View Options

install_mac/2-release-qt.sh

Loading...
View Options

install_mac/3-dmg.sh

Loading...
View Options

install_mac/marble_mac.jpg

Loading...
View Options

src/apps/marble-qt/CMakeLists.txt

Loading...
View Options

tools/create_dmg/background.jpg

Loading...
View Options

tools/create_dmg/create.py

Loading...
View Options

tools/create_dmg/prepare.scpt

Loading...