Refresh the ScreenGeometry data role whenever a screen is added or changes its geometry.
ClosedPublic
Actions

Authored by hein on Dec 8 2016, 10:46 PM.

Details

Reviewers

Group Reviewers

Commits

R871:0b0d14639a1a: Refresh the ScreenGeometry data role whenever a screen is added or changes its…
R120:0b0d14639a1a: Refresh the ScreenGeometry data role whenever a screen is added or changes its…

Summary

As this happens the screen filtering higher up in the proxy chain
culimating in TasksModel needs to be re-executed, as it compares
ScreenGeometry against a property value set on the model. Without
this update, tasks may disappear from views using TasksModel.

Mapping the trigger conditions to affected rows is deliberately
maximally coarse; see implementation comment in code.

BUG:373075

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein updated this revision to Diff 8875.Dec 8 2016, 10:46 PM

hein retitled this revision from to Refresh the ScreenGeometry data role whenever a screen is added or changes its geometry..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added reviewers: Plasma, davidedmundson.

hein added a subscriber: plasma-devel.

Restricted Application added a project: Plasma. · View Herald TranscriptDec 8 2016, 10:46 PM

davidedmundson accepted this revision.Dec 9 2016, 11:09 AM

davidedmundson edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2016, 11:09 AM

Closed by commit R120:0b0d14639a1a: Refresh the ScreenGeometry data role whenever a screen is added or changes its… (authored by hein). · Explain WhyDec 9 2016, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		libtaskmanager/CMakeLists.txt (2 lines)
A	M	libtaskmanager/abstractwindowtasksmodel.h (53 lines)
A	M	libtaskmanager/abstractwindowtasksmodel.cpp (60 lines)
M		libtaskmanager/waylandtasksmodel.h (4 lines)
M		libtaskmanager/waylandtasksmodel.cpp (2 lines)
M		libtaskmanager/xwindowtasksmodel.h (4 lines)
M		libtaskmanager/xwindowtasksmodel.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8875	d1ea67c		Dec 8 2016, 10:46 PM	★	★
Diff 2	8893	29523d3	R120:0b0d14639a1a0eb2766d74daa3358c0939b6d8b3	Dec 9 2016, 4:50 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d11f762cba2c	e87caf4711f6	d1ea67c1fcf0	Eike Hein	Refresh the ScreenGeometry data role whenever a screen is added or changes its… (Show More…)	Dec 8 2016, 10:41 PM