Electric car charging stations
ClosedPublic

Authored by xdizzaster on Dec 8 2016, 5:51 PM.

Details

Summary

Now the OSM Vector map can show electric car charging stations and their respective tags using the new charging station icon.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
xdizzaster updated this revision to Diff 8861.Dec 8 2016, 5:51 PM
xdizzaster retitled this revision from to Electric car charging stations.
xdizzaster updated this object.
xdizzaster edited the test plan for this revision. (Show Details)
xdizzaster added reviewers: nienhueser, rahn.
xdizzaster set the repository for this revision to R34 Marble.
xdizzaster added a project: Marble.
xdizzaster added a subscriber: Marble.
xdizzaster updated this revision to Diff 8867.Dec 8 2016, 7:56 PM

Removed some stuff that should not have been there and which I don't know how it got there.

xdizzaster updated this revision to Diff 8868.Dec 8 2016, 8:38 PM

The previous patch wouldn't apply due to a trailing whitespace.

nienhueser requested changes to this revision.Dec 8 2016, 9:16 PM
nienhueser edited edge metadata.

Thanks for the updates :-) Looks good, just needs some minor tweaking to have the texts appear correctly for users.

src/lib/marble/declarative/Placemark.cpp
263

Each of these will only appear as a number to the user. Please use "%1 Volt" and likewise instead.

265

Please use "%1 blue CEE sockets". This way the actual number will appear in the text visible to users. Same for the other ones below.

This revision now requires changes to proceed.Dec 8 2016, 9:16 PM

Thanks for your feedback, will update shortly.

xdizzaster updated this revision to Diff 8874.Dec 8 2016, 9:39 PM
xdizzaster edited edge metadata.

Updated the tag text shown to the user to show the number of sockets, volts, etc.

xdizzaster marked 2 inline comments as done.Dec 8 2016, 9:39 PM
xdizzaster updated this revision to Diff 8889.Dec 9 2016, 1:10 PM
xdizzaster edited edge metadata.

Updated for the latest upstream master branch.

This revision was automatically updated to reflect the committed changes.