Add Art Shops and Cave Entrances
ClosedPublic
Actions

Authored by spencerb on Dec 7 2016, 11:13 PM.

Details

Reviewers

nienhueser
rahn

Group Reviewers

Marble

Commits

R34:ce2a75ba5d66: Add Art Shops and Cave Entrances

Summary

GCI task: ARTWORK SHOP AND CAVE ENTRANCE IN MARBLE VECTOR OPENSTREETMAP (KDE)

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

spencerb retitled this revision from to Add Art Shops and Cave Entrances.

spencerb updated this object.

spencerb edited the test plan for this revision. (Show Details)

spencerb set the repository for this revision to R34 Marble.

spencerb added a project: Marble.

Thanks. Some issues left, but I'll fix them when I commit it, no need for a new patch.

src/lib/marble/StyleBuilder.cpp
855	"cave" should be "cave_entrance"
src/lib/marble/declarative/Placemark.cpp
154	General tags like this are handled independent of the category, so this line is not needed. Same for some more below.
160	copy and paste error, "yes" should be "limited"

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/marble/StyleBuilder.cpp (7 lines)
M			src/lib/marble/declarative/Placemark.cpp (17 lines)
M			src/lib/marble/geodata/data/GeoDataPlacemark.h (2 lines)
M			src/lib/marble/geodata/data/GeoDataPlacemark.cpp (2 lines)
M			src/plugins/runner/osm/OsmNode.cpp (2 lines)