Differential D3557

[Notifications] Default initialize notificationProperties as empty object
ClosedPublic
Actions

Authored by broulik on Dec 1 2016, 10:46 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:f78c98068a34: [Notifications] Default initialize notificationProperties as empty object
R120:f78c98068a34: [Notifications] Default initialize notificationProperties as empty object
Summary

Avoids accessing the object twice for every property and improves readability.

Test Plan

Notification title, text, icon still work. Configure button also shows up properly and so do the thumbnails. No (additional) warnings printed on console

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 8665.Dec 1 2016, 10:46 AM
broulik retitled this revision from to [Notifications] Default initialize notificationProperties as empty object.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 1 2016, 10:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 1 2016, 12:56 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Dec 1 2016, 12:56 PM
Closed by commit R120:f78c98068a34: [Notifications] Default initialize notificationProperties as empty object (authored by broulik). · Explain WhyDec 1 2016, 1:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8673

View Options

applets/notifications/package/contents/ui/NotificationPopup.qml

Loading...