Differential D3538

Drop resize animation when adding pages
ClosedPublic
Actions

Authored by apol on Nov 29 2016, 3:11 PM.

Tags

Subscribers

jensreuterberg, colomar, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R169:aabcb7b0d6e1: Drop resize animation when adding pages

Summary

It's a bit glitchy and looks a bit odd

Test Plan

Current: https://youtu.be/pUjmqis9E-w
NoAnimations: https://youtu.be/iqQfkOhObBE

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol updated this revision to Diff 8604.Nov 29 2016, 3:11 PM

apol retitled this revision from to Drop resize animation when adding pages.

apol updated this object.

apol edited the test plan for this revision. (Show Details)

apol added reviewers: Kirigami, mart.

Restricted Application added a project: Kirigami. · View Herald TranscriptNov 29 2016, 3:11 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

+1, definitely looks better to me (and Jens will love any killed animation, anyway ;) )

Lovelly! <3

The animations remaining feel way cleaner

mart added inline comments.Nov 30 2016, 2:12 PM

src/controls/templates/private/PageRow.qml
429–430	if the interval went to 0, then couldn't be possible to remove the timer completely?

Remove Timer

Fix patch

Fix patch

apol marked an inline comment as done.Dec 1 2016, 11:17 AM

mart accepted this revision.Dec 1 2016, 11:17 AM

mart edited edge metadata.

This revision is now accepted and ready to land.Dec 1 2016, 11:17 AM

Closed by commit R169:aabcb7b0d6e1: Drop resize animation when adding pages (authored by apol). · Explain WhyDec 1 2016, 11:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/controls/templates/private/PageRow.qml (29 lines)

Diff 8670

src/controls/templates/private/PageRow.qml

Loading...