Hide progress bar after all jobs finished.
ClosedPublic
Actions

Authored by wcpan on Nov 29 2016, 9:32 AM.

Details

Reviewers

mwolff
antonanikin

Group Reviewers

KDevelop

Commits

Summary

This is a follow-up of D3110, which keeps the progress bar showing
after parsing completed. This patch will properly hide the probress bar.

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wcpan retitled this revision from to Hide progress bar after all jobs finished..

wcpan updated this object.

wcpan edited the test plan for this revision. (Show Details)

wcpan added a reviewer: KDevelop.

wcpan added a subscriber: kdevelop-devel.

Now progress bar hides at end of work, thanks.

This revision is now accepted and ready to land.Nov 29 2016, 10:59 AM

lgtm, btw - as a follow up, writing unit tests for this code would be appreciated. Google Code In tasks?

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			language/backgroundparser/backgroundparser.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8596	971290e		Nov 29 2016, 9:32 AM	★	★
Diff 2	8642	357f492	R33:ceae10c925b01536a0848b85f1cfa70b308eb85c	Nov 30 2016, 6:48 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
371d942e0169	72752533ab69	971290efb4e7	Wei-Cheng Pan	Hide progress bar after all jobs finished. (Show More…)	Nov 29 2016, 4:57 AM