Differential D3533

Select correct index without timer
ClosedPublic
Actions

Authored by mart on Nov 28 2016, 5:38 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:d9d52a37c6ba: Select correct index without timer
Summary

remove the timer that selects the index at startup
that caused flickering and things moving around since
index 0 got selected, then moved to the correct one only after a while.

Test Plan

correct theme gets highlighed at startup
probably i'll port l&f kcm currentSelectedIndex property to indexOf
invokable as well.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 8575.Nov 28 2016, 5:38 PM
mart retitled this revision from to Select correct index without timer.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2016, 5:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 29 2016, 2:04 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Nov 29 2016, 2:04 PM
Closed by commit R119:d9d52a37c6ba: Select correct index without timer (authored by mart). · Explain WhyNov 29 2016, 2:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8602

View Options

kcms/desktoptheme/kcm.h

Loading...
View Options

kcms/desktoptheme/kcm.cpp

Loading...
View Options

kcms/desktoptheme/package/contents/ui/main.qml

Loading...