Differential D3523

Fix resizing of infopanel
ClosedPublic
Actions

Authored by rthomsen on Nov 27 2016, 4:57 PM.

Details

Reviewers
kde-i18n-doc
yurchor
elvisangelaccio
Commits
R36:7a5e4e4c402e: Fix resizing of infopanel
Summary

KSqueezedTextLabel doesn't rich text. This causes the used <b> and </b> to sometimes become visible when the infopanel is reduced in size.

We split the text up into two parts: The left-most is a QLabel (because it has predictable horizontal size) with the title and the right-most is a KSqueezedTextLLabel with the value. The left-side one can then be set to bold font.

This changes some strings slightly (the %1 are removed from some strings) and it's meant for Applications/16.12 branch which is now in string freeze. Hence: Can someone from kde-i18n-doc please approve this?

Test Plan

Select an entry in any archive and resize the infopanel. Check that the labels "look good".

Diff Detail

Repository
R36 Ark
Lint
Lint Skipped
Unit
Unit Tests Skipped
rthomsen updated this revision to Diff 8550.Nov 27 2016, 4:57 PM
rthomsen retitled this revision from to Fix resizing of infopanel.
rthomsen updated this object.
rthomsen edited the test plan for this revision. (Show Details)
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to R36 Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptNov 27 2016, 4:57 PM
rthomsen updated this revision to Diff 8552.Nov 27 2016, 5:08 PM
rthomsen updated this object.
rthomsen added a reviewer: kde-i18n-doc.

Added a missing space after a colon.

elvisangelaccio requested changes to this revision.Nov 27 2016, 5:28 PM
elvisangelaccio edited edge metadata.
elvisangelaccio added inline comments.
part/infopanel.cpp
178

The "fixed" string can now be set directly in infopanel.ui

This revision now requires changes to proceed.Nov 27 2016, 5:28 PM
rthomsen updated this revision to Diff 8554.Nov 27 2016, 5:38 PM
rthomsen edited edge metadata.

Set the text of the fixed QLabels in the .ui file instead of in the .cpp file.

rthomsen marked an inline comment as done.Nov 27 2016, 5:38 PM
rthomsen updated this revision to Diff 8555.Nov 27 2016, 5:53 PM
rthomsen updated this object.
rthomsen edited edge metadata.

Use a QGridLayout instead of the QFormLayout because the latter doesn't support hidden rows (Qt Bug Report).

elvisangelaccio accepted this revision.Nov 27 2016, 6:10 PM
elvisangelaccio edited edge metadata.

Code is ok, let's wait for i18n approval

yurchor accepted this revision.Nov 27 2016, 6:27 PM
yurchor added a reviewer: yurchor.
yurchor added a subscriber: yurchor.

+1 from Ukrainian translation team

Closed by commit R36:7a5e4e4c402e: Fix resizing of infopanel (authored by rthomsen). · Explain WhyNov 29 2016, 6:03 PM
This revision was automatically updated to reflect the committed changes.
rthomsen mentioned this in R36:7a5e4e4c402e: Fix resizing of infopanel.

Revision Contents
Changeset List

PathPackages
Mpart/infopanel.cpp (23 lines)
Mpart/infopanel.ui (100 lines)

Diff 8552

View Options

part/infopanel.cpp

Loading...
View Options

part/infopanel.ui

Loading...