Details
- Reviewers
graesslin - Group Reviewers
Plasma - Commits
- R108:59515b1681a8: Scale QPainter x11 windowed backend
Diff Detail
- Repository
- R108 KWin
- Lint
No Linters Available - Unit
No Unit Test Coverage
| autotests/integration/scene_qpainter_test.cpp | ||
|---|---|---|
| 199 ↗ | (On Diff #8683) | you don't need to do the Test::setupWaylandConnection in the test, that's part of the init() |
| 202–203 ↗ | (On Diff #8683) | the idea of the Test::createShellSurface variant returning a QObject is to have a test_data() with the two supported modes, so that we test both WlShell and XdgShellUnstableV5. You can compare with other tests. If you want to only test WlShell there is a simplified setup method returning a ShellSurface instead of QObject. |
| 230–231 ↗ | (On Diff #8683) | why are you saving to the tmp directory? |
| autotests/integration/scene_qpainter_test.cpp | ||
|---|---|---|
| 202–203 ↗ | (On Diff #8683) | I don't really need a shell surface at all, I can just remove this. |
| autotests/integration/scene_qpainter_test.cpp | ||
|---|---|---|
| 202–203 ↗ | (On Diff #8683) | the test is called "testWindowScaled", but doesn't create a window. I'm slightly confused. |
| autotests/integration/scene_qpainter_test.cpp | ||
|---|---|---|
| 202–203 ↗ | (On Diff #8683) | It creates a surface on line 200. What's the difference between a top level mapped surface and a window? |
| autotests/integration/scene_qpainter_test.cpp | ||
|---|---|---|
| 202–203 ↗ | (On Diff #8683) | A surface is something you can attach a buffer to. It's not a window but a wrapper for anything which might need a buffer. E.g. a cursor image. That's what you use in this test. You can create a window from a surface by creating a wl_shell or xgd_shell surface (note it's also called a surface) from it. This will on KWin side then create a ShellClient which represents a window. And I think that's what you want to test as that's what needs to be scaled. |
| autotests/integration/scene_qpainter_test.cpp | ||
|---|---|---|
| 202–203 ↗ | (On Diff #8683) | yeah, sorry. I got confused. You were right. |