fix config dialogs in ltr mode
ClosedPublic
Actions

Authored by mart on Nov 22 2016, 1:42 PM.

Details

Reviewers

Group Reviewers

Commits

R120:7355b783c28a: fix config dialogs in ltr mode
R120:cf2d9d96581b: fix config dialogs in ltr mode
R871:cf2d9d96581b: fix config dialogs in ltr mode
R871:7355b783c28a: fix config dialogs in ltr mode

Summary

anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled

CCBUG:372721

Test Plan

opened all config dialogs both in ltr and ltr layouts

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mart updated this revision to Diff 8402.Nov 22 2016, 1:42 PM

mart retitled this revision from to fix config dialogs in ltr mode.

mart updated this object.

mart edited the test plan for this revision. (Show Details)

mart added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptNov 22 2016, 1:42 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson accepted this revision.Nov 22 2016, 1:58 PM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.Nov 22 2016, 1:58 PM

Closed by commit R120:cf2d9d96581b: fix config dialogs in ltr mode (authored by mart). · Explain WhyNov 22 2016, 2:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/analog-clock/contents/ui/configGeneral.qml (1 line)
M			applets/calendar/package/contents/ui/configGeneral.qml (1 line)
M			applets/devicenotifier/package/contents/ui/configGeneral.qml (1 line)
M			applets/digital-clock/package/contents/ui/configAppearance.qml (1 line)
M			applets/digital-clock/package/contents/ui/configCalendar.qml (1 line)
M			applets/lock_logout/contents/ui/ConfigGeneral.qml (1 line)
M			applets/notifications/package/contents/ui/configNotifications.qml (1 line)
M			applets/systemmonitor/common/contents/ui/ConfigGeneral.qml (1 line)
M			applets/systemtray/package/contents/ui/ConfigGeneral.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8402	889be45		Nov 22 2016, 1:42 PM	★	★
Diff 2	8406	3c0b31b	rPLASMAWORKSPACEcf2d9d96581bd79b3a5b1c0a7674857d451734ac	Nov 22 2016, 2:00 PM	★	★