Remove useless branching on EGL/GLX in GLPlatform
ClosedPublic
Actions

Authored by graesslin on Nov 22 2016, 6:46 AM.

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

Summary

The code for EGL and GLX platform did the same checks, just with the
difference that the EGL check has another check for isGLES.

So let's just do the branching on whether isGLES or GL.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Remove useless branching on EGL/GLX in GLPlatform.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added a project: KWin. · View Herald TranscriptNov 22 2016, 6:46 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

mart added a reviewer: mart.

This revision is now accepted and ready to land.Nov 22 2016, 10:02 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libkwineffects/kwinglplatform.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8370	451bbb5		Nov 22 2016, 6:46 AM	★	★
Diff 2	8399	451bbb5	rKWINb1e258d1e933bdd96d4e42b070379737793e69df	Nov 22 2016, 6:46 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
b0225dd50f65	b2984e4df36e	451bbb54ddf8	Martin Gräßlin	Remove useless branching on EGL/GLX in GLPlatform (Show More…)	Nov 22 2016, 6:44 AM