Instead of making PanelViewConfig manipulate the visibiltyMode of PanelView, make PanelView force the view to be visible whilst the config is open. This is cleaner as it doesn't alter the original config, and resolves a bug that opening configure with an autohide panel would shift contents about.
Details
Details
With panel as autohide opened config
Moused away from panel, panel stayed visible
With panel as autohide, plugged in a USB pen - panel appeared - and closed when I hid the dialog
Changed mode in panel config, panel didn't immediately change - but did on close.
Tested with all modes.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
in general +1, seems a bit cleaner one it's all well tested, it's ok for me
| shell/panelview.cpp | ||
|---|---|---|
| 578 | why this got commented out? (that's the one that should be really checked thoroughly) | |