temporary visible panels out of availableScreenRect
AbandonedPublic
Actions

Authored by mart on Nov 17 2016, 3:56 PM.

Details

Reviewers

Group Reviewers

Summary

when an autohide panel is being configured its visibility
is updated to not make it hide until the panel controller is open

this influences availableScreenrect/availableScreenRegion
and makes widgets to move around when the controller is open.

check the visibility stored in the controller as well in order to
exclude those panels from the available computation
added api is not super beautiful but seems to me the least
invasive as a "realvisibility" "pretendedvisibility"
distinction in panelview would be worse

BUG:372248

Test Plan

tried with an autohide panel, doesn't move widgets
anymore when the controller is open

Diff Detail

Repository

R120 Plasma Workspace

Branch

phab/availablescreenrect

Lint

No Linters Available

Unit

No Unit Test Coverage

mart updated this revision to Diff 8281.Nov 17 2016, 3:56 PM

mart retitled this revision from to temporary visible panels out of availableScreenRect.

mart updated this object.

mart edited the test plan for this revision. (Show Details)

mart added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptNov 17 2016, 3:56 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Diff sounds messed up?

This revision now requires changes to proceed.Nov 17 2016, 3:59 PM

se on 5.8

try to rebase

mart abandoned this revision.Nov 17 2016, 4:36 PM

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (11 lines)
M		applets/clipboard/contents/ui/ClipboardPage.qml (6 lines)
M		applets/systemtray/package/contents/ui/ConfigEntries.qml (2 lines)
M		applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml (1 line)
M		applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml (4 lines)
M		applets/systemtray/package/contents/ui/main.qml (48 lines)
M		applets/systemtray/systemtray.h (8 lines)
M		applets/systemtray/systemtray.cpp (87 lines)
M		appmenu/appmenu.desktop (1 line)
M		components/shellprivate/widgetexplorer/widgetexplorer.h (18 lines)
M		components/shellprivate/widgetexplorer/widgetexplorer.cpp (72 lines)
M		dataengines/statusnotifieritem/statusnotifieritemsource.cpp (9 lines)
M		dataengines/systemmonitor/systemmonitor.h (3 lines)
M		dataengines/systemmonitor/systemmonitor.cpp (17 lines)
M		doc/config_update_tool/extract_config.py (4 lines)
M		doc/kcontrol/screenlocker/index.docbook (17 lines)
M		drkonqi/bugzillaintegration/reportassistantpages_base.cpp (6 lines)
M		drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp (3 lines)
M		freespacenotifier/freespacenotifier.desktop (1 line)
M		kioslave/remote/CMakeLists.txt (3 lines)
M		kioslave/remote/kdedmodule/CMakeLists.txt (2 lines)
M		kioslave/remote/kdedmodule/remotedirnotify.h (8 lines)
M		kioslave/remote/kdedmodule/remotedirnotify.cpp (66 lines)
M		kioslave/remote/kdedmodule/remotedirnotifymodule.cpp (4 lines)
M		kioslave/remote/kio_remote.cpp (12 lines)
M		kioslave/remote/remoteimpl.h (6 lines)
M		kioslave/remote/remoteimpl.cpp (40 lines)
D	M	kioslave/remote/tests/CMakeLists.txt (15 lines)
D	M	kioslave/remote/tests/testremote.h (34 lines)
D	M	kioslave/remote/tests/testremote.cpp (51 lines)
M		klipper/clipcommandprocess.h (2 lines)
M		krunner/CMakeLists.txt (2 lines)
A	M	krunner/update/CMakeLists.txt (12 lines)
A	M	krunner/update/krunnerplugins.upd (3 lines)
A	M	krunner/update/main.cpp (67 lines)
M		krunner/view.cpp (3 lines)
M		ksmserver/client.cpp (2 lines)
M		ksmserver/logout-greeter/CMakeLists.txt (2 lines)
M		ksmserver/main.cpp (7 lines)
M		ksmserver/server.cpp (16 lines)
M		ksmserver/shutdown.cpp (18 lines)
M		ksmserver/shutdowndlg.cpp (6 lines)
M		ksmserver/startup.cpp (10 lines)
M		ksmserver/switchuserdialog.cpp (5 lines)
M		kuiserver/main.cpp (2 lines)
M		libtaskmanager/abstracttasksmodel.h (1 line)
M		libtaskmanager/autotests/launchertasksmodeltest.cpp (1 line)
M		libtaskmanager/launchertasksmodel.h (40 lines)
M		libtaskmanager/launchertasksmodel.cpp (401 lines)
A	M	libtaskmanager/launchertasksmodel_p.h (66 lines)
M		libtaskmanager/taskfilterproxymodel.cpp (4 lines)
M		libtaskmanager/tasksmodel.h (40 lines)
M		libtaskmanager/tasksmodel.cpp (63 lines)
M		libtaskmanager/tasktools.h (16 lines)
M		libtaskmanager/tasktools.cpp (38 lines)
M		libtaskmanager/waylandtasksmodel.cpp (75 lines)
M		libtaskmanager/xwindowtasksmodel.cpp (110 lines)
M		lookandfeel/contents/lockscreen/LockScreenUi.qml (237 lines)
M		lookandfeel/contents/lockscreen/MainBlock.qml (15 lines)
M		plasma-windowed/plasmawindowedcorona.cpp (2 lines)
M		runners/CMakeLists.txt (4 lines)
M		runners/activities/plasma-runner-activityrunner.desktop (1 line)
M		runners/baloo/baloosearchrunner.cpp (6 lines)
M		runners/baloo/plasma-runner-baloosearch.desktop (1 line)
M		runners/bookmarks/bookmarksrunner.cpp (3 lines)
M		runners/calculator/plasma-runner-calculator.desktop (1 line)
M		runners/kill/plasma-runner-kill.desktop (1 line)
M		runners/locations/plasma-runner-locations.desktop (1 line)
M		runners/places/plasma-runner-places.desktop (1 line)
M		runners/services/plasma-runner-services.desktop (1 line)
M		runners/sessions/sessionrunner.cpp (1 line)
M		runners/shell/plasma-runner-shell.desktop (3 lines)
M		runners/webshortcuts/plasma-runner-webshortcuts.desktop (1 line)
M		runners/windowedwidgets/plasma-runner-windowedwidgets.desktop (1 line)
M		runners/windowedwidgets/windowedwidgetsrunner.h (2 lines)
M		runners/windowedwidgets/windowedwidgetsrunner.cpp (48 lines)
M		runners/windows/plasma-runner-windows.desktop (1 line)
M		runners/windows/windowsrunner.cpp (2 lines)
M		sddm-theme/Background.qml (86 lines)
M		sddm-theme/Main.qml (7 lines)
M		sddm-theme/theme.conf (2 lines)
M		shell/CMakeLists.txt (1 line)
M		shell/alternativeshelper.cpp (6 lines)
M		shell/containmentconfigview.cpp (2 lines)
M		shell/desktopview.cpp (1 line)
M		shell/panelview.h (16 lines)
M		shell/panelview.cpp (160 lines)
M		shell/scripting/containment.cpp (4 lines)
M		shell/scripting/widget.cpp (2 lines)
M		shell/shellcorona.h (4 lines)
M		shell/shellcorona.cpp (41 lines)
D	M	shell/waylanddialogfilter.h (57 lines)
D	M	shell/waylanddialogfilter.cpp (117 lines)
M		solidautoeject/solidautoeject.desktop (2 lines)
M		startkde/kcminit/main.cpp (1 line)
M		startkde/startkde.cmake (79 lines)
M		systemmonitor/kdedksysguard.cpp (1 line)
M		templates/ion-dataengine/ion-dataengine.kdevtemplate (4 lines)
M		wallpapers/image/image.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8281	dbb7f8a		Nov 17 2016, 3:56 PM	★	★
Diff 2	8282	9e457e8	se on 5.8	Nov 17 2016, 4:20 PM	★	★
Diff 3	8283	dbb7f8a	try to rebase	Nov 17 2016, 4:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f247a244528a	227e90cdeb3b	dbb7f8aecfb3	Marco Martin	temporary visible panels out of availableScreenRect (Show More…)	Nov 17 2016, 3:43 PM

temporary visible panels out of availableScreenRectAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 8283

CMakeLists.txt

applets/clipboard/contents/ui/ClipboardPage.qml

applets/systemtray/package/contents/ui/ConfigEntries.qml

applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

applets/systemtray/package/contents/ui/main.qml

applets/systemtray/systemtray.h

applets/systemtray/systemtray.cpp

appmenu/appmenu.desktop

components/shellprivate/widgetexplorer/widgetexplorer.h

components/shellprivate/widgetexplorer/widgetexplorer.cpp

dataengines/statusnotifieritem/statusnotifieritemsource.cpp

dataengines/systemmonitor/systemmonitor.h

dataengines/systemmonitor/systemmonitor.cpp

doc/config_update_tool/extract_config.py

doc/kcontrol/screenlocker/index.docbook

drkonqi/bugzillaintegration/reportassistantpages_base.cpp

drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp

freespacenotifier/freespacenotifier.desktop

kioslave/remote/CMakeLists.txt

kioslave/remote/kdedmodule/CMakeLists.txt

kioslave/remote/kdedmodule/remotedirnotify.h

kioslave/remote/kdedmodule/remotedirnotify.cpp

kioslave/remote/kdedmodule/remotedirnotifymodule.cpp

kioslave/remote/kio_remote.cpp

kioslave/remote/remoteimpl.h

kioslave/remote/remoteimpl.cpp

kioslave/remote/tests/CMakeLists.txt

kioslave/remote/tests/testremote.h

kioslave/remote/tests/testremote.cpp

klipper/clipcommandprocess.h

krunner/CMakeLists.txt

krunner/update/CMakeLists.txt

krunner/update/krunnerplugins.upd

krunner/update/main.cpp

krunner/view.cpp

ksmserver/client.cpp

ksmserver/logout-greeter/CMakeLists.txt

ksmserver/main.cpp

ksmserver/server.cpp

ksmserver/shutdown.cpp

ksmserver/shutdowndlg.cpp

ksmserver/startup.cpp

ksmserver/switchuserdialog.cpp

kuiserver/main.cpp

libtaskmanager/abstracttasksmodel.h

libtaskmanager/autotests/launchertasksmodeltest.cpp

libtaskmanager/launchertasksmodel.h

libtaskmanager/launchertasksmodel.cpp

libtaskmanager/launchertasksmodel_p.h

libtaskmanager/taskfilterproxymodel.cpp

libtaskmanager/tasksmodel.h

libtaskmanager/tasksmodel.cpp

libtaskmanager/tasktools.h

libtaskmanager/tasktools.cpp

libtaskmanager/waylandtasksmodel.cpp

libtaskmanager/xwindowtasksmodel.cpp

lookandfeel/contents/lockscreen/LockScreenUi.qml

lookandfeel/contents/lockscreen/MainBlock.qml

plasma-windowed/plasmawindowedcorona.cpp

runners/CMakeLists.txt

runners/activities/plasma-runner-activityrunner.desktop

runners/baloo/baloosearchrunner.cpp

runners/baloo/plasma-runner-baloosearch.desktop

runners/bookmarks/bookmarksrunner.cpp

runners/calculator/plasma-runner-calculator.desktop

runners/kill/plasma-runner-kill.desktop

runners/locations/plasma-runner-locations.desktop

runners/places/plasma-runner-places.desktop

runners/services/plasma-runner-services.desktop

runners/sessions/sessionrunner.cpp

runners/shell/plasma-runner-shell.desktop

runners/webshortcuts/plasma-runner-webshortcuts.desktop

runners/windowedwidgets/plasma-runner-windowedwidgets.desktop

runners/windowedwidgets/windowedwidgetsrunner.h

temporary visible panels out of availableScreenRect
AbandonedPublic
Actions

Revision Contents
Changeset List