Differential D3377

Words: redo "Change Shape Properties" command on every redo, not only first time
ClosedPublic
Actions

Authored by danders on Nov 16 2016, 9:58 AM.

Details

Reviewers
boemann
Commits
R8:c471a2235eda: Words: redo "Change Shape Properties" command on every redo, not only first time
Summary

Test:
Add a shape
Change ancoring to inline
undo, redo -> shape is not inlined

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders updated this revision to Diff 8203.Nov 16 2016, 9:58 AM
danders retitled this revision from to Words: redo "Change Shape Properties" command on every redo, not only first time.
danders updated this object.
danders edited the test plan for this revision. (Show Details)
danders added a reviewer: boemann.
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptNov 16 2016, 9:58 AM
boemann edited edge metadata.Nov 16 2016, 10:11 AM

That is a very scary thing to play with so I cant approve just like that - will have to test thoroughly later

danders added a comment.Nov 16 2016, 1:20 PM

Ok, to help you along...
Tested with 2.8.1 (latest I have) and there this works, and the code also includes the very 2 lines of this patch.
They were however removed by this:
commit afc20ccace208fb86a43ed401084377eb06c80a5
Author: C. Boemann <cbo@boemann.dk>
Date: Thu Jan 15 13:04:40 2015 +0100

Make sure we also apply the runaround properties to the shape on first redo

BUG: 329301
boemann accepted this revision.Nov 23 2016, 10:10 PM
boemann edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 10:10 PM
Closed by commit R8:c471a2235eda: Words: redo "Change Shape Properties" command on every redo, not only first time (authored by danders). · Explain WhyNov 24 2016, 11:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8472

View Options

words/part/dialogs/KWFrameDialog.cpp

Loading...