[effects] Show a notification when a screenshot got saved to file
ClosedPublic

Authored by graesslin on Nov 16 2016, 8:52 AM.

Details

Summary

Inform the user about the path to where a screenshot got saved through a
notification. This is helpful on the one hand that the user sees that
the screenshot got saved and from a security perspective that the user
is informed when a screenshot is taken through the dbus interface. It
doesn't prevent non-authorized screenshot taking, but at least the user
is informed about it.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8201.Nov 16 2016, 8:52 AM
graesslin retitled this revision from to [effects] Show a notification when a screenshot got saved to file.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma, VDG.
Restricted Application added a project: KWin. · View Herald TranscriptNov 16 2016, 8:52 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

@andreask do we have an icon action/screenshot or something like that?

mart accepted this revision.Nov 16 2016, 11:50 AM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
effects/screenshot/screenshot.cpp
249

I think for this thing, spectacle is the right icon, as it's the only thing that is presented to the user "this makes a screenshot"

This revision is now accepted and ready to land.Nov 16 2016, 11:50 AM
This revision was automatically updated to reflect the committed changes.

I think so to, use the spectacle icon as it is now.