Differential D3371

Forward description signal in CreateJob
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 15 2016, 5:17 PM.

Details

Reviewers
rthomsen
Commits
R36:0e1653f48acd: Fix description signal regression in CreateJob
Summary

We need to use a lambda because we need to change the this parameter (so a
simple connect(addJob, &KJob::description, this, &KJob::description) does not
work).

Test Plan

Create an archive from dolphin and check the system tray.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 8173.Nov 15 2016, 5:17 PM
elvisangelaccio retitled this revision from to Forward description signal in CreateJob.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptNov 15 2016, 5:17 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Nov 15 2016, 6:08 PM
rthomsen edited edge metadata.
rthomsen added inline comments.
kerfuffle/jobs.cpp
439

Needless empty line.

This revision is now accepted and ready to land.Nov 15 2016, 6:08 PM
Closed by commit R36:0e1653f48acd: Fix description signal regression in CreateJob (authored by elvisangelaccio). · Explain WhyNov 15 2016, 6:25 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:0e1653f48acd: Fix description signal regression in CreateJob.

Revision Contents
Changeset List

PathPackages
Mkerfuffle/jobs.cpp (5 lines)

Diff 8178

View Options

kerfuffle/jobs.cpp

Loading...