Differential D3359

Show warning when using AES encryption with zip
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 14 2016, 6:22 PM.

Details

Reviewers
rthomsen
Commits
R36:046b20925845: Show warning when using AES encryption with zip
Summary

This shows a messagewidget with Warning type above the encryption method
combobox. The message is shown only when using AES with zip archives (make sure
to apply https://git.reviewboard.kde.org/r/129405/ to kwidgetsaddons, otherwise
it will be always visible when expanding the groupbox).

Test Plan

Choose zip + AES in CreateDialog, make sure messagewidget is visible.
Make sure it's hidden otherwise.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 8139.Nov 14 2016, 6:22 PM
elvisangelaccio retitled this revision from to Show warning when using AES encryption with zip.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptNov 14 2016, 6:22 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Nov 15 2016, 6:04 PM
rthomsen edited edge metadata.

Fix it then ship it! :)

kerfuffle/compressionoptionswidget.ui
167

Please change text to: "This encryption method may not be supported by older archiving software."

This revision is now accepted and ready to land.Nov 15 2016, 6:04 PM
elvisangelaccio marked an inline comment as done.Nov 15 2016, 6:18 PM
Closed by commit R36:046b20925845: Show warning when using AES encryption with zip (authored by elvisangelaccio). · Explain WhyNov 15 2016, 6:25 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:046b20925845: Show warning when using AES encryption with zip.

Revision Contents
Changeset List

Diff 8177

View Options

kerfuffle/compressionoptionswidget.h

Loading...
View Options

kerfuffle/compressionoptionswidget.cpp

Loading...
View Options

kerfuffle/compressionoptionswidget.ui

Loading...