Differential D3356

[Windowed Widgets Runner] Don't access invalid KPluginMetaData
ClosedPublic
Actions

Authored by broulik on Nov 14 2016, 9:30 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:59b2d1effcee: [Windowed Widgets Runner] Don't access invalid KPluginMetaData
R871:59b2d1effcee: [Windowed Widgets Runner] Don't access invalid KPluginMetaData
Summary

BUG: 372017
FIXED-IN: 5.8.4

Test Plan

Compiles. Didn't have the crash but that's what the backtrace tells me.
I don't understand why listAppletMetaData returns invalid metadata to begin with but system tray also checks for validity and better safe than sorry...

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 8128.Nov 14 2016, 9:30 AM
broulik retitled this revision from to [Windowed Widgets Runner] Don't access invalid KPluginMetaData.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2016, 9:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 14 2016, 1:39 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Nov 14 2016, 1:39 PM
Closed by commit R120:59b2d1effcee: [Windowed Widgets Runner] Don't access invalid KPluginMetaData (authored by broulik). · Explain WhyNov 14 2016, 2:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8137

View Options

runners/windowedwidgets/windowedwidgetsrunner.cpp

Loading...