Differential D3354

expose panel thickness to the client side
AbandonedPublic
Actions

Authored by mvourlakos on Nov 13 2016, 10:07 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

this is a way for the client panel implementation
to access the thickness variable of the panel.
the client must set in its root qml element
property int thickness

FEATURE: 368488

Test Plan

tested with the corresponding code

Diff Detail

Repository
R119 Plasma Desktop
Branch
thickness
Lint
No Linters Available
Unit
No Unit Test Coverage
mvourlakos updated this revision to Diff 8125.Nov 13 2016, 10:07 PM
mvourlakos retitled this revision from to expose panel thickness to the client side.
mvourlakos updated this object.
mvourlakos edited the test plan for this revision. (Show Details)
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 13 2016, 10:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested changes to this revision.Nov 13 2016, 10:18 PM
davidedmundson edited edge metadata.
davidedmundson added inline comments.
desktoppackage/contents/views/Panel.qml
75

We can't do this, it's making an optimistic assumption about the ordering of objects, which is prone to change.

If we go for this, it needs to be in some defined interface like we did for backgroundHints.

I'm not sure quite what yet, I'll discuss back on your main thread.

This revision now requires changes to proceed.Nov 13 2016, 10:18 PM
mvourlakos updated this object.Nov 13 2016, 10:23 PM
mvourlakos edited edge metadata.
mvourlakos added a comment.Nov 13 2016, 10:31 PM

No problem for me, to implement an alternative if you can point me in the right direction...

What we need then is an interface in order to give the client the possibility to set thickness and the maskArea, a patch which I have sent a little before...

Maybe a PanelInterface ?

mvourlakos abandoned this revision.Mar 13 2018, 9:26 PM

Revision Contents
Changeset List

Diff 8125

View Options

desktoppackage/contents/views/Panel.qml

Loading...