Differential D3350

Stop crashing when lsar's output is too big
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 12 2016, 5:51 PM.

Details

Reviewers
rthomsen
Commits
R36:0b981c544e99: Stop crashing when lsar's output is too big
Summary

lsar can generate huge json output when listing big solid rar archives.
This will be fixed in lsar, but meanwhile we can catch a bad_alloc if we're
using an affected version of lsar.

BUG: 372210
FIXED-IN: 16.12.0

Test Plan

Open the archive attached in the bug report with cliunarchiver and make sure
Ark shows an error message instead of crashing.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 8113.Nov 12 2016, 5:51 PM
elvisangelaccio retitled this revision from to Stop crashing when lsar's output is too big.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptNov 12 2016, 5:51 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Nov 15 2016, 6:21 PM
rthomsen edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 6:21 PM
Closed by commit R36:0b981c544e99: Stop crashing when lsar's output is too big (authored by elvisangelaccio). · Explain WhyNov 15 2016, 6:25 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:0b981c544e99: Stop crashing when lsar's output is too big.

Revision Contents
Changeset List

Diff 8179

View Options

autotests/plugins/cliunarchiverplugin/CMakeLists.txt

Loading...
View Options

plugins/cliunarchiverplugin/CMakeLists.txt

Loading...
View Options

plugins/cliunarchiverplugin/cliplugin.cpp

Loading...