Differential D3348

Show an error when trying to extract AES-encrypted archives with clizip
AbandonedPublic
Actions

Authored by elvisangelaccio on Nov 12 2016, 12:09 PM.

Details

Reviewers
rthomsen
Summary

unzip cannot extract AES-encrypted archives and exits with error code 81 when
this happens. We can catch this error code and show a relevant error message to
the users.

Test Plan

Try to extract an AES-encrypted entry with clizip.

Diff Detail

Repository
R36 Ark
Branch
unzip-aes-error
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 8111.Nov 12 2016, 12:09 PM
elvisangelaccio retitled this revision from to Show an error when trying to extract AES-encrypted archives with clizip.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptNov 12 2016, 12:09 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen requested changes to this revision.Nov 12 2016, 6:13 PM
rthomsen edited edge metadata.

According to this, the exit code 81 is used both for unsupported encryption and compression method. This should be reflected in the error message.

This revision now requires changes to proceed.Nov 12 2016, 6:13 PM
elvisangelaccio updated this revision to Diff 8115.Nov 12 2016, 6:16 PM
elvisangelaccio edited edge metadata.
  • Also mention compression method in the error message
rthomsen accepted this revision.Nov 12 2016, 6:28 PM
rthomsen edited edge metadata.
This revision is now accepted and ready to land.Nov 12 2016, 6:28 PM
elvisangelaccio abandoned this revision.Nov 12 2016, 6:33 PM

@rthomsen has a better fix in mind

Revision Contents
Changeset List

PathPackages
Mkerfuffle/cliinterface.cpp (7 lines)

Diff 8115

View Options

kerfuffle/cliinterface.cpp

Loading...