Differential D3308

[taskmanagerrulesrc] Add Rewrite Rule for Google-chrome
ClosedPublic
Actions

Authored by broulik on Nov 8 2016, 1:43 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R120:7c443aa53900: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome
R871:7c443aa53900: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome
Summary

Google Chrome needlessly changed its window class class to Google-chrome (was google-chrome previously) breaking our launcher mapping.

BUG: 372211
FIXED-IN: 5.8.4

Test Plan

There was a logic error in the code where it would overwrite the service again even if we found one using our mapping, will be addressed in an upcoming patch.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 8014.Nov 8 2016, 1:43 PM
broulik retitled this revision from to [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 8 2016, 1:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein requested changes to this revision.Nov 8 2016, 1:49 PM
hein edited edge metadata.

Can you add a comment explaining the why?

This revision now requires changes to proceed.Nov 8 2016, 1:49 PM
broulik updated this revision to Diff 8017.Nov 8 2016, 1:50 PM
broulik edited edge metadata.

Add comment

hein accepted this revision.Nov 8 2016, 1:51 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 1:51 PM
Closed by commit R120:7c443aa53900: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome (authored by broulik). · Explain WhyNov 8 2016, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibtaskmanager/taskmanagerrulesrc (7 lines)

Diff 8020

View Options

libtaskmanager/taskmanagerrulesrc

Loading...