Convert virtual backend to per screen rendering
ClosedPublic
Actions

Authored by davidedmundson on Nov 7 2016, 11:48 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Output scaling can't ever work on a single buffer; especially if they're
different scales and overlapping.

This ports the virtual backend to perScreenRendering so that I can use it for
tests.

ctest fails here, but it fails on the tests that it failed on before..

Repository

R108 KWin

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

davidedmundson retitled this revision from to Convert virtual backend to per screen rendering.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2016, 11:48 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

code looks fine to me. Which tests are failing for you?

kwin-testPointerInput
kwin-testDontCrashEmptyDeco (which freezes)
kwin-testSceneOpenGL
kwin-testGlobalShortcuts
....

at this point I think there's something wrong with my system rather than the code.

Compile against master rather than scaling branch

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptNov 9 2016, 12:36 PM

does the sceneqpaintertest pass? That's probably the only one which could be affected by this change.

does the sceneqpaintertest pass? That's probably the only one which could be affected by this change.

Yes, that passes

graesslin added a reviewer: graesslin.

This revision is now accepted and ready to land.Nov 11 2016, 12:48 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/platforms/virtual/scene_qpainter_virtual_backend.h (7 lines)
M			plugins/platforms/virtual/scene_qpainter_virtual_backend.cpp (30 lines)
M			plugins/platforms/virtual/screens_virtual.h (1 line)
M			plugins/platforms/virtual/virtual_backend.h (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7999	03a6b1e		Nov 7 2016, 11:48 PM	★	★
Diff 2	8037	002d667	Compile against master rather than scaling branch	Nov 9 2016, 12:36 PM	★	★
Diff 3	8091	4f4d9d5	rKWIN1776b5f927881e5c0733170a810a094caa16b64f	Nov 11 2016, 12:56 PM	★	★