Port to KDevelop::Stack
ClosedPublic

Authored by kfunk on Sep 6 2015, 4:58 PM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Commits
R32:2067f9739ce4: Port to KDevelop::Stack

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 766.Sep 6 2015, 4:58 PM
kfunk retitled this revision from to Port to KDevelop::Stack.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 6 2015, 4:58 PM
kfunk added a project: KDevelop.
mwolff added a subscriber: mwolff.Sep 6 2015, 6:04 PM

in general +1, nice!

languages/qmljs/codecompletion/context.cpp
250 ↗(On Diff #766)

bind to const& to prevent copying

languages/qmljs/duchain/expressionvisitor.h
22

unused, remove

projectmanagers/cmake/duchain/usebuilder.h
24

unused, remove

projectmanagers/cmake/parser/cmakelistsparser.cpp
27

unused, remove

kfunk added a comment.Sep 8 2015, 8:16 PM

This patch is on hold as I've started to see random crashes in kdev-clang during parsing; I'll first check if it's related to this patch.

mwolff accepted this revision.Oct 8 2015, 10:09 AM
mwolff added a reviewer: mwolff.

if you figure out the issue is related to this patch then fix it, otherwise +1 :)

This revision is now accepted and ready to land.Oct 8 2015, 10:09 AM
This revision was automatically updated to reflect the committed changes.