Differential D3294

[kioslave/desktop] Port away from kdelibs4support
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 7 2016, 2:09 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:f81c843dcfb3: [kioslave/desktop] Port away from kdelibs4support
R871:f81c843dcfb3: [kioslave/desktop] Port away from kdelibs4support
Summary

All the targets now build without linking to kdelibs4support

Test Plan
  • desktop:// still works in Dolphin.
  • ~/Desktop is automatically created if missing
  • unit test still passes

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 7974.Nov 7 2016, 2:09 PM
elvisangelaccio retitled this revision from to [kioslave/desktop] Port away from kdelibs4support.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 7 2016, 2:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 22 2016, 10:29 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Nov 22 2016, 10:29 AM
Closed by commit R120:f81c843dcfb3: [kioslave/desktop] Port away from kdelibs4support (authored by elvisangelaccio). · Explain WhyNov 22 2016, 11:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8391

View Options

kioslave/desktop/CMakeLists.txt

Loading...
View Options

kioslave/desktop/desktopnotifier.cpp

Loading...
View Options

kioslave/desktop/kio_desktop.cpp

Loading...
View Options

kioslave/desktop/tests/CMakeLists.txt

Loading...
View Options

kioslave/desktop/tests/kio_desktop_test.cpp

Loading...