| mwolff |
| KDevelop |
See class documentation for more details.
When using KDevelop::Stack instead of QStack the heap allocations go almost done to zero
within KDevelop. QStack::pop in particular is implemented *very*
inefficient, every call causes a realloc b/c QStack tries to squeeze the
container.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
lgtm in general! thanks
| language/duchain/problem.h | ||
|---|---|---|
| 31 ↗ | (On Diff #769) | remove, seems to be unused? |
| language/duchain/types/typeregister.h | ||
| 120 ↗ | (On Diff #769) | just remove this? |
| language/util/setrepository.cpp | ||
| 19 ↗ | (On Diff #769) | remove, seems to be unused |
| util/stack.h | ||
| 53 ↗ | (On Diff #769) | please put these on multiple lines, following the KDev coding style |