Import konqueror kcm docbooks from kde-runtime master
ClosedPublic

Authored by lueck on Nov 5 2016, 9:39 PM.

Details

Summary

doc/kcontrol/bookmarks/ doc/kcontrol/filemanager/ doc/kcontrol/history/ doc/kcontrol/kcmcss/ doc/kcontrol/khtml-adblock/ doc/kcontrol/khtml-behavior/ doc/kcontrol/khtml-general/ doc/kcontrol/khtml-java-js/ doc/kcontrol/khtml-plugins/ doc/kcontrol/performance/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the CMakeLists.txt and the dtd have to be adapted to kf5 and the docs need proofreading

If this is pushed to kde-baseapps master, these kcontrol subdirs in plasma-desktop, where they are unchanged since import from kde-runtime, have to be removed

Should we use use the subdir name kcontrol or kcontrol5 to be co-installable resp. to use a consistent subdir name?

See also https://git.reviewboard.kde.org/r/128803/

Test Plan

history looks good

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck updated this revision to Diff 7931.Nov 5 2016, 9:39 PM
lueck retitled this revision from to Import konqueror kcm docbooks from kde-runtime master.
lueck updated this object.
lueck edited the test plan for this revision. (Show Details)
lueck added reviewers: dfaure, Documentation.
lueck set the repository for this revision to R226 Konqueror.
dfaure added inline comments.Nov 6 2016, 8:01 PM
doc/kcontrol/khtml-adblock/index.docbook
4 ↗(On Diff #7931)

you can remove this line, in all files, I think

doc/kcontrol/khtml-java-js/index.docbook
33 ↗(On Diff #7931)

(Hmm, ouch, this does still exist indeed, but I doubt it has any effect.
The JS part of this is useful, but probably not the Java part. But OK, don't change the docu yet, this needs investigation first.)

doc/kcontrol/khtml-plugins/index.docbook
30 ↗(On Diff #7931)

You can remove it all

80 ↗(On Diff #7931)

nsplugins is gone, it was KHTML only.

doc/kcontrol/performance/index.docbook
49 ↗(On Diff #7931)

I killed all that GUI, by the way...

The "Performance" KCM now only has 2 checkboxes related to preloading, but all that stuff about configuring reuse is gone (what happens now is that preloaded instances are used, but existing processes/windows are never reused).

(commit eb16174)

lueck added a comment.Nov 6 2016, 8:47 PM

David, thanks for your review.
Most of the issues you raised are already on my todo list for the next review.
As I pointed out in the Summary these docbooks are added to the konqueror repos as they were splitted from kde-runtime master.
They are not included in build so far, the CMakeLists.txt and the dtd have to be adapted to kf5 and the docs need proofreading.
I'd like to add the docbooks in the current state first and add all necessary changes in the next review/commit to get a cleaner
history, so you can see how the kcm docbooks were added to the repo and what was changed later.

dfaure accepted this revision.Nov 6 2016, 9:41 PM
dfaure edited edge metadata.

No problem.

This revision is now accepted and ready to land.Nov 6 2016, 9:41 PM
This revision was automatically updated to reflect the committed changes.